Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding WalletConnect data to peer list and slices #1985

Open
wants to merge 1 commit into
base: add-wc-connect
Choose a base branch
from

Conversation

dianasavvatina
Copy link

@dianasavvatina dianasavvatina commented Oct 2, 2024

Proposed changes

Adding peers for WalletConnect

  • adding walletconnect to slices
  • updating peer list on connect and disconnect

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

Steps to reproduce

  1. Rejecting
    actions: on dApp - connect, copy link. on Wallet: Connect, reject
    result: on Wallet - Approve button is inactive. On reject - modal is closed immediately. on dApp: modal is closed

  2. Approving
    actions: on dApp - connect, copy link. on Wallet: on Wallet: Connect, select Account, Approve
    result: on dApp - connected, the list of actions is shown. on Wallet: the modal is closed, the list of peers contains the dApp (name, account, network, button to disconnect)
    actions: on dApp - request transaction
    result: on dApp - transaction is immediately rejected with USER rejected error

  3. Disconnecting from Wallet
    actions: connect with approve; click Disconnect on Wallet
    result: on Wallet: dapp is removed from the list. on Dapp - state changes to disconnected

  4. Disconnecting from dApp
    actions: connect with approve; click Disconnect on dApp
    result: on Wallet: dapp is removed from the list; toast shows which dApp disconnected. on dApp - state changes to disconnected

Screenshots

image image image

Checklist

  • Tests that prove my fix is effective or that my feature works have been added
  • Documentation has been added (if appropriate)
  • Screenshots are added (if any UI changes have been made)
  • All TODOs have a corresponding task created (and the link is attached to it)

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umami-v2-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 10:11am
umami-v2-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 10:11am

@dianasavvatina dianasavvatina force-pushed the add-wc-connect branch 3 times, most recently from 22d7d7c to 275ec93 Compare October 3, 2024 15:22
@dianasavvatina dianasavvatina force-pushed the add-wc-connect branch 2 times, most recently from 000c6e6 to ffcbede Compare October 4, 2024 13:46
@dianasavvatina dianasavvatina changed the title WIP: Adding WalletConnect data to peer list and slices feat: Adding WalletConnect data to peer list and slices Oct 18, 2024
@dianasavvatina dianasavvatina marked this pull request as ready for review October 18, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant